[PATCH] D28778: Use a test fixture for LoopInfoTest.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 22:20:07 PST 2017


sanjoy requested changes to this revision.
sanjoy added inline comments.
This revision now requires changes to proceed.


================
Comment at: unittests/Analysis/LoopInfoTest.cpp:27
+    // Create the new dominator tree and loop info and free the old ones.
+    DT.reset(new DominatorTree(F));
+    LI.reset(new LoopInfo(*DT));
----------------
Not sure what you're getting out of making this a fixture.  Why can't `DT` adn `LI` live as locals within `runWithLoopInfo`?


https://reviews.llvm.org/D28778





More information about the llvm-commits mailing list