[PATCH] D28760: [AMDGPU] Add target information that is required by static analyzer tool to metadata

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h:50
+  virtual void EmitRuntimeMetadata(const FeatureBitset &Features,
+                                   Module &M) = 0;
 
----------------
should Module be const?


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h:74
 
-  void EmitRuntimeMetadata(Module &M) override;
+  void EmitRuntimeMetadata(const FeatureBitset &Features, Module &M) override;
 
----------------
Ditto


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h:105
 
-  void EmitRuntimeMetadata(Module &M) override;
+  void EmitRuntimeMetadata(const FeatureBitset &Features, Module &M) override;
 
----------------
Ditto


https://reviews.llvm.org/D28760