[lld] r291944 - Don't add DT_INIT/DT_FINI for undef and shared symbols.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 07:11:29 PST 2017


Sean Silva <chisophugis at gmail.com> writes:

>>  template <class ELFT>
>> +SymbolBody *SymbolTable<ELFT>::findDefined(StringRef Name) {
>>
>
> Can you make this name more specific so that it captures the intent of what
> this function does better?

I agree that "defined" is a bit overloaded, but not think of anything
better ("local" is also overloaded). Maybe findInCurrentDSO?

Cheers,
Rafael


More information about the llvm-commits mailing list