[PATCH] D28086: [CMake] Subsume LLVMBuild.txt. Disabled by default.

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added a reviewer: chapuni.
chapuni added a comment.

I don't understand why you suggest WITHOUT_LLVMBUILD. We can just prune llvmbuild.

You may do the job step-by-step,

1. Let llvm-config free from llvmbuild
2. Migrate deps from LLVMBuild.txt(s)
3. Prune llvmbuild

I also think LINK_COMPONENTS would be redundant since it comes from compatibility for autoconf.
We may take LLVMSupport instead of Support, for example.

That said, I am not a fan of direct use of target_link_libraries. It is not controllable.
I suggest to use LINK_LIBS in llvm_add_library().


Repository:
  rL LLVM

https://reviews.llvm.org/D28086