[PATCH] D28743: [PM] Teach the LoopPassManager to automatically canonicalize loops by runnig LCSSA over them prior to running the loop pipeline.

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff added inline comments.


================
Comment at: include/llvm/Transforms/Scalar/LoopPassManager.h:308-310
+      // Verify the loop structure and LCSSA form before visiting the loop.
+      L->verifyLoop();
+      L->isRecursivelyLCSSAForm(LAR.DT, LI);
----------------
davide wrote:
> These two can be a bit expensive. Maybe put them under `#ifndef NDEBUG` ?
In D28676 the same problem were solved by making `VerifyLoopInfo` global and running expensive checks only if `-verify-loop-info` is specified in command line. Maybe that change can be useful here?


https://reviews.llvm.org/D28743