[PATCH] D28742: [InstCombine] Don't DSE across readnone functions that may throw

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 14 23:49:33 PST 2017


majnemer added a comment.

Instead of using `I->mayReadFromMemoryOrThrow() || I->mayWriteToMemory()`, I'd recommend using `I->mayReadFromMemory() || I->mayHaveSideEffects()`

`mayReadFromMemoryOrThrow` is a rather strange predicate...


https://reviews.llvm.org/D28742





More information about the llvm-commits mailing list