[PATCH] D28313: Change which input sections we concatenate

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 14 19:39:30 PST 2017


Ed Maste <emaste at freebsd.org> writes:

> On 13 January 2017 at 17:28, Rafael Avila de Espindola
> <rafael.espindola at gmail.com> wrote:
>>
>> Just checking: You have your fix for RELRO copy relocations
>> applied, right? I started a build a couple of hours ago with that hacked
>> out of lld and so far it is building just fine.
>
> Yes, and I tried with relro support disabled altogether in rtld as well.
>
> It turns out this is PR31221 again -- i.e., LLD went back to emitting
> a zeroed GOT, and FreeBSD PR214972 (to avoid relying on a
> pre-populated GOT) is not yet addressed.

Was it ever really "fixed"? Reading r288451 I am pretty sure it only
changed the output for !RelTy::IsRela.

Cheers,
Rafael


More information about the llvm-commits mailing list