[PATCH] D28627: [PM] Introduce an analysis set used to preserve all analyses over a function's CFG when that CFG is unchanged.

[Justin Lebar via Phabricator via llvm-commits]

jlebar accepted this revision.
jlebar added a comment.

I like it!



================
Comment at: include/llvm/IR/PassManager.h:105
+/// between them. Mutating a branch instruction or basic block is enough to
+/// invalidate the CFG.
+class AnalysesOnFunctionCFG {
----------------
chandlerc wrote:
> jlebar wrote:
> > Can you clarify what you mean by "mutating a basic block"?  I would think that adding (say) an `add` instruction to a BB does not affect the CFG, but does "mutate" the BB.
> Sorry, I meant mutating the *set* of BBs. IE, adding or removing BBs. I also made the branch mutation comment much more accurate and precise (I hope).
Yes, this comment is much better now.


https://reviews.llvm.org/D28627