[PATCH] D28587: [SCEV] Make getUDivExactExpr handle non-nuw multiplies correctly

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

Can I ask you to please to (in a later commit) change `createSCEV` to use `getUDivExactExpr` for `udiv exact` instructions, and add some tests around what you're changing here?



================
Comment at: lib/Analysis/ScalarEvolution.cpp:7248
         GetMinTrailingZeros(Distance) >= StepV.countTrailingZeros()) {
       // Here we've constrained the equation to be of the form
       //
----------------
I think we can basically drop this whole comment.


https://reviews.llvm.org/D28587