[PATCH] D28731: [PATCH] Fix warning about parentheses in boolean expression.
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 14 12:55:12 PST 2017
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292031: [NewGVN] Fix a warning from GCC. (authored by davide).
Changed prior to commit:
https://reviews.llvm.org/D28731?vs=84461&id=84463#toc
Repository:
rL LLVM
https://reviews.llvm.org/D28731
Files:
llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
Index: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
+++ llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
@@ -1076,13 +1076,12 @@
// dominator tree, or the new class leader should dominate the new member
// instruction. We simply check that the member instruction does not properly
// dominate the new class leader.
- assert(
- !isa<Instruction>(NewClass->RepLeader) || !NewClass->RepLeader ||
- I == NewClass->RepLeader ||
- !DT->properlyDominates(
- I->getParent(),
- cast<Instruction>(NewClass->RepLeader)->getParent()) &&
- "New class for instruction should not be dominated by instruction");
+ assert((!isa<Instruction>(NewClass->RepLeader) || !NewClass->RepLeader ||
+ I == NewClass->RepLeader ||
+ !DT->properlyDominates(
+ I->getParent(),
+ cast<Instruction>(NewClass->RepLeader)->getParent())) &&
+ "New class for instruction should not be dominated by instruction");
if (NewClass->RepLeader != I) {
auto DFSNum = InstrDFS.lookup(I);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28731.84463.patch
Type: text/x-patch
Size: 1168 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170114/e1b7d1f2/attachment.bin>
More information about the llvm-commits
mailing list