[PATCH] D28700: [NVPTX] Let there be One True Way to set NVVMReflect params.

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 14 10:57:20 PST 2017


jlebar added a comment.

Argh, this is actually wrong.  I forgot that we already have a ftz function attribute.  We should use that and completely nix the module attr.

I think the right thing is:

- Use https://reviews.llvm.org/D28538 to set the ftz attr on libdevice functions.
- Add attr-merging logic for the ftz attr so it behaves like the fastmath function attr.  (I believe the merging logic is, if the callee lacks fastmath, the caller has fastmath stripped from it.  But whatever the logic is, we should just do the same thing, I think.)
- Change nvvm-reflect to look at the function-level ftz attr rather than the module ftz attr.
- Stop setting the module-level ftz attr in clang.


https://reviews.llvm.org/D28700





More information about the llvm-commits mailing list