[PATCH] D28717: COFF: Change the /lldmap output format to be more like the ELF linker.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 19:00:11 PST 2017


pcc marked 2 inline comments as done.
pcc added inline comments.


================
Comment at: lld/COFF/MapFile.cpp:37
+
+static void writeOutSecLine(raw_fd_ostream &OS, int Width, uint64_t Address,
+                            uint64_t Size, uint64_t Align, StringRef Name) {
----------------
ruiu wrote:
> It is unfortunate that you had to copy that much code, but honestly I have no good idea to avoid that because the code here is slightly different at a lot of places.
Right, the only real common part here is these 30 or so lines, and it didn't seem worth splitting that out into a library.


https://reviews.llvm.org/D28717





More information about the llvm-commits mailing list