[PATCH] D28617: Implement -Map

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 13:18:15 PST 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ================
> Comment at: lld/ELF/MapFile.cpp:39
> +  OS << format_hex_no_prefix(Address, 8) << ' ' << format_hex_no_prefix(Size, 8)
> +     << ' ' << format("%5x ", Align) << left_justify(Name, 7);
> +}
> ----------------
> This and in other write* functions probably should print out a trailing "\n" so that you don't need to do that in `writeMapFile2`.

They cannot. They forward to one another to align.

Cheers,
Rafael


More information about the llvm-commits mailing list