[PATCH] D28681: [AArch64] Enable Rounding Double Multiply Add/Subtract instructions on Falkor.
Chad Rosier via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 13 12:32:25 PST 2017
mcrosier added inline comments.
================
Comment at: test/CodeGen/AArch64/arm64-neon-v8.1a.ll:2
; RUN: llc < %s -verify-machineinstrs -mtriple=arm64-eabi -aarch64-neon-syntax=generic | FileCheck %s --check-prefix=CHECK-V8a
+; RUN: llc < %s -verify-machineinstrs -mtriple=arm64-eabi -mattr=+rdm -aarch64-neon-syntax=generic | FileCheck %s --check-prefix=CHECK-RDM
; RUN: llc < %s -verify-machineinstrs -mtriple=arm64-eabi -mattr=+v8.1a -aarch64-neon-syntax=generic | FileCheck %s --check-prefix=CHECK-V81a
----------------
ab wrote:
> Maybe add --check-prefix=CHECK-RDM to the v8.1a line, and remove the rdm CHECK-V81a lines?
I'm not sure I follow, Ahmed. Are you suggesting that I not add an additional RUN line and replace
; RUN: llc < %s -verify-machineinstrs -mtriple=arm64-eabi -mattr=+v8.1a -aarch64-neon-syntax=generic | FileCheck %s --check-prefix=CHECK-V81a
with
; RUN: llc < %s -verify-machineinstrs -mtriple=arm64-eabi -mattr=+rdm -aarch64-neon-syntax=generic | FileCheck %s --check-prefix=CHECK-RDM
and update the CHECK-V81a directives to CHECK-RDM?
I'm happy to do that, I just want to confirm that is what you were suggesting.
https://reviews.llvm.org/D28681
More information about the llvm-commits
mailing list