[PATCH] D28581: Change DWARFDie::getAttributeValue() to DWARFDie::find(), add DWARFDie::findRecurse() and dwarf::toString() helper functions.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 11:09:48 PST 2017


aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFFormValue.h:203
+      return V->getAsUnsignedConstant();
+    return None;
+  }
----------------
aprantl wrote:
> Could this be replaced by getValueOr or does the type system prohibit that?
Oh sorry, I just realized that I misread the function signature of this. This comment of mine makes no sense at all ;-)


https://reviews.llvm.org/D28581





More information about the llvm-commits mailing list