dberlin accepted this revision. dberlin added a comment. This revision is now accepted and ready to land. this looks correct. i wonder at what point we should start adding at least docstring tests to this code. https://reviews.llvm.org/D28572