[PATCH] D28684: [Support/Compression] - Change zlib API to return Error instead of custom status.

[Rafael Avila de Espindola via llvm-commits]

George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> -zlib::Status zlib::compress(StringRef InputBuffer,
> -                            SmallVectorImpl<char> &CompressedBuffer,
> -                            CompressionLevel Level) {
> -  return zlib::StatusUnsupported;
> -}
> -zlib::Status zlib::uncompress(StringRef InputBuffer, char *UncompressedBuffer,
> -                              size_t &UncompressedSize) {
> -  return zlib::StatusUnsupported;
> -}
> -zlib::Status zlib::uncompress(StringRef InputBuffer,
> -                              SmallVectorImpl<char> &UncompressedBuffer,
> -                              size_t UncompressedSize) {
> -  return zlib::StatusUnsupported;
> +Error zlib::compress(StringRef InputBuffer,
> +                     SmallVectorImpl<char> &CompressedBuffer,
> +                     CompressionLevel Level) {
> +  llvm_unreachable("zlib::compress is unavailable");
> +}
> +Error zlib::uncompress(StringRef InputBuffer, char *UncompressedBuffer,
> +                       size_t &UncompressedSize) {
> +  llvm_unreachable("zlib::uncompress is unavailable");
> +}
> +Error zlib::uncompress(StringRef InputBuffer,
> +                       SmallVectorImpl<char> &UncompressedBuffer,
> +                       size_t UncompressedSize) {
> +  llvm_unreachable("zlib::uncompress is unavailable");

Why are these unreachable now?

Cheers,
Rafael