[PATCH] D28515: [Support] - Introduce zlib::toString(zlib::Status)
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 13 01:32:59 PST 2017
grimar added a comment.
In https://reviews.llvm.org/D28515#644772, @davide wrote:
> As an alternative, you can merge the patch and the patch where you plan to use this code together (which would make more sense, IMHO).
> In fact, I'm still confused why you splitted this in the first place.
I wanted to use it in LLD. That would mean 2 patches anyways, LLD and this one.
Previously Rafael suggested to return Error for methods of this API instead of status.
I think that is good idea, result will be single patch affecting users of this (Decomressor class, something else probably) and changing API itself in a single patch, just like you suggesting.
https://reviews.llvm.org/D28515
More information about the llvm-commits
mailing list