[PATCH] D28225: Implemented color coding and Vertex labels in XRay Graph

[Alexis Shaw via Phabricator via llvm-commits]

varno added inline comments.


================
Comment at: tools/llvm-xray/xray-graph.cc:264-270
+  M.Count  = std::max(M.Count,  S.Count);
+  M.Min    = std::max(M.Min,    S.Min);
+  M.Median = std::max(M.Median, S.Median);
+  M.Pct90  = std::max(M.Pct90,  S.Pct90);
+  M.Pct99  = std::max(M.Pct99,  S.Pct99);
+  M.Max    = std::max(M.Max,    S.Max);
+  M.Sum    = std::max(M.Sum,    S.Sum);
----------------
dblaikie wrote:
> Could use a member pointer & a helper function (possibly template) to maybe make these shorter/more reliable (by only having to mention the member name once - less chance of accidentally mismatching them).
Discussion resulted in this comment being seen as not easy to do due to specifics.


https://reviews.llvm.org/D28225