[PATCH] D28628: [asan] Don't overalign global metadata.

Evgeniy Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 15:26:36 PST 2017


eugenis added inline comments.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1624-1627
+    unsigned SizeOfGlobalStruct = DL.getTypeAllocSize(Initializer->getType());
+    assert(isPowerOf2_32(SizeOfGlobalStruct) &&
+           "global metadata will not be padded appropriately");
+    Metadata->setAlignment(SizeOfGlobalStruct);
----------------
pcc wrote:
> Move to `InstrumentGlobalsCOFF`?
of course!


Repository:
  rL LLVM

https://reviews.llvm.org/D28628





More information about the llvm-commits mailing list