[PATCH] D27900: [ELF] - Keep the source file/line location information separate from the object file location information.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Your comment makes me wonder why you changed something like `foo.c:35: <error message>` to `foo.c: <error message>\nnote: location is 35` in the first place. The former is a familiar format, no? I don't see a justification on that change.

A problem of this patch is it introduced a "note" message and change a lot of messages at the same time. You want to focus on only one thing at a time for ease of development/code review.



================
Comment at: ELF/Error.h:28
 #include "lld/Core/LLVM.h"
-
+#include "llvm/ADT/ArrayRef.h"
 #include "llvm/Support/Error.h"
----------------
Remove


================
Comment at: ELF/SymbolTable.cpp:360
 static void reportDuplicate(SymbolBody *Existing, InputFile *NewFile) {
-  print("duplicate symbol " + conflictMsg(Existing, NewFile));
+  print("duplicate symbol " + conflictMsg(Existing, NewFile), {});
 }
----------------
`{}` -> ""


https://reviews.llvm.org/D27900