[PATCH] D28581: Change DWARFDie::getAttributeValue() to DWARFDie::find(), add DWARFDie::findRecurse() and dwarf::toString() helper functions.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 11:27:03 PST 2017


aprantl added a comment.

Now that the default values are part of the to<type>() functions this doesn't look to bad either. It's still strictly better and shorter than the original code.

Since I'm on the fence now and Greg says he can live with both options and David is arguing strongly for this variant, let's do this one.


https://reviews.llvm.org/D28581





More information about the llvm-commits mailing list