[PATCH] D28191: [IR] Don't call assertModuleIsMaterialized in release builds
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 12 09:28:12 PST 2017
I think we have to keep it to avoid unused variable warnings when the
assert at the end of the function disappears in release builds.
~Craig
On Thu, Jan 12, 2017 at 6:51 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:
> Craig Topper via Phabricator <reviews at reviews.llvm.org> writes:
> > -void Value::assertModuleIsMaterialized() const {
> > +void Value::assertModuleIsMaterializedImpl() const {
> > #ifndef NDEBUG
>
> Do we want to keep this NDEBUG?
>
> LGTM either way.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170112/8efbe3e7/attachment.html>
More information about the llvm-commits
mailing list