[PATCH] D28613: Alternative proposal to https://reviews.llvm.org/D28581 where we return a DWARFormValue from DWARFDie::find*() functions

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 09:20:25 PST 2017


clayborg created this revision.
clayborg added reviewers: dblaikie, probinson, aam, llvm-commits.
Herald added a subscriber: jgosnell.

This code seems to be more natural as it keeps things cleaner and more readable. I prefer this option over the one in https://reviews.llvm.org/D28581.

Did this to allow us to compare the two approaches to see which one we like better.


https://reviews.llvm.org/D28613

Files:
  include/llvm/DebugInfo/DWARF/DWARFDie.h
  include/llvm/DebugInfo/DWARF/DWARFFormValue.h
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFDie.cpp
  lib/DebugInfo/DWARF/DWARFFormValue.cpp
  lib/DebugInfo/DWARF/DWARFTypeUnit.cpp
  lib/DebugInfo/DWARF/DWARFUnit.cpp
  tools/dsymutil/DwarfLinker.cpp
  tools/obj2yaml/dwarf2yaml.cpp
  unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28613.84134.patch
Type: text/x-patch
Size: 48286 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170112/2adda2d5/attachment.bin>


More information about the llvm-commits mailing list