[PATCH] D28107: [ELF] - Do not create huge garbage files on section offset overflow.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 06:55:03 PST 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> I think I suggested this before, but I'd suggest using uint64_t instead of uintX_t to keep a file size. On 32-bit, if a file size is >4GB, you want to report an error.

This is somewhat independent, no? It seems a good idea to exit before
creating the file if we know there was an error.

Cheers,
Rafael


More information about the llvm-commits mailing list