[lld] r291752 - [ELF] - Make x86 unknown relocations messages to be consistent with x64 ones
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 12 01:09:15 PST 2017
Author: grimar
Date: Thu Jan 12 03:09:15 2017
New Revision: 291752
URL: http://llvm.org/viewvc/llvm-project?rev=291752&view=rev
Log:
[ELF] - Make x86 unknown relocations messages to be consistent with x64 ones
Addded quotes to be consistent with x64 messages,
where quotes were used for nicer reporting 'Unknown' relocations initially.
Modified:
lld/trunk/ELF/Target.cpp
lld/trunk/test/ELF/unknown-reloc.s
Modified: lld/trunk/ELF/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=291752&r1=291751&r2=291752&view=diff
==============================================================================
--- lld/trunk/ELF/Target.cpp (original)
+++ lld/trunk/ELF/Target.cpp Thu Jan 12 03:09:15 2017
@@ -386,7 +386,7 @@ RelExpr X86TargetInfo::getRelExpr(uint32
case R_386_NONE:
return R_HINT;
default:
- error("do not know how to handle relocation " + toString(Type) + " (" +
+ error("do not know how to handle relocation '" + toString(Type) + "' (" +
Twine(Type) + ")");
return R_HINT;
}
Modified: lld/trunk/test/ELF/unknown-reloc.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/unknown-reloc.s?rev=291752&r1=291751&r2=291752&view=diff
==============================================================================
--- lld/trunk/test/ELF/unknown-reloc.s (original)
+++ lld/trunk/test/ELF/unknown-reloc.s Thu Jan 12 03:09:15 2017
@@ -3,8 +3,8 @@
# RUN: llvm-mc -filetype=obj -triple=i386-pc-linux-gnu %S/Inputs/unknown-reloc.s -o %t2.o
# RUN: not ld.lld %t1.o %t2.o -o %t.out 2>&1 | FileCheck %s
-# CHECK: do not know how to handle relocation R_386_PC8 (23)
-# CHECK: do not know how to handle relocation R_386_8 (22)
+# CHECK: do not know how to handle relocation 'R_386_PC8' (23)
+# CHECK: do not know how to handle relocation 'R_386_8' (22)
.text
.global foo
More information about the llvm-commits
mailing list