[PATCH] D28580: [CMake][libcxx] Check that we have libcxxabi before using it

[Ivan Krasin via Phabricator via llvm-commits]

krasin added inline comments.


================
Comment at: CMakeLists.txt:122
   )
-  if (IS_DIRECTORY "${LIBCXX_LIBCXXABI_INCLUDES_INTERNAL}")
+  if (NOT (LIBCXX_STANDALONE_BUILD AND NOT HAVE_LIBCXXABI) AND
+      IS_DIRECTORY "${LIBCXX_LIBCXXABI_INCLUDES_INTERNAL}")
----------------
This condition is hard to read. What's about

```
if (HAVE_LIBCXXABI OR NOT LIBCXX_STANDALONE_BUILD) AND
    IS_DIRECTORY "${LIBCXX_LIBCXXABI_INCLUDES_INTERNAL}")
```

Also, can you please elaborate the parts of this condition a bit? I don't follow the logic. How do HAVE_LIBCXXABI, LIBCXX_STANDALONE_BUILD and LIBCXX_LIBCXXABI_INCLUDES_INTERNAL play with each other?


Repository:
  rL LLVM

https://reviews.llvm.org/D28580