[llvm] r291709 - [NewGVN] Strengthen a couple of assertions.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 13:49:01 PST 2017


Author: davide
Date: Wed Jan 11 15:49:00 2017
New Revision: 291709

URL: http://llvm.org/viewvc/llvm-project?rev=291709&view=rev
Log:
[NewGVN] Strengthen a couple of assertions.

StoreCount >= 0 on `unsigned` is always true, otherwise.

Modified:
    llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp?rev=291709&r1=291708&r2=291709&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp Wed Jan 11 15:49:00 2017
@@ -1063,10 +1063,10 @@ void NewGVN::moveValueToNewCongruenceCla
   OldClass->Members.erase(V);
   NewClass->Members.insert(V);
   if (isa<StoreInst>(V)) {
+    assert(OldClass->StoreCount > 0 && "Store count underflow detected");
     --OldClass->StoreCount;
-    assert(OldClass->StoreCount >= 0);
+    assert(NewClass->StoreCount < UINT_MAX && "Store count overflow detected");
     ++NewClass->StoreCount;
-    assert(NewClass->StoreCount >= 0);
   }
 
   ValueToClass[V] = NewClass;




More information about the llvm-commits mailing list