[PATCH] D28337: [InstCombine] if the condition of a select is known, eliminate the select

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 12:08:01 PST 2017


spatel added a comment.

In https://reviews.llvm.org/D28337#643135, @efriedma wrote:

> I think we need a more comprehensive approach to analyzing value ranges/known bits/etc., but this is fine for now, I think.


Thanks! And agreed - if there's consensus about how to fix this (nonnull and llvm.assume are my motivations in this series of patches), I'll try to improve it.


https://reviews.llvm.org/D28337





More information about the llvm-commits mailing list