[PATCH] D28550: [X86][AVX512] Fix PR31515 - Do not flip vselect condition if it's not a vXi1 mask

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 11:59:01 PST 2017


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:28754
       SDValue CondNew = DAG.getNode(ISD::XOR, DL, Cond.getValueType(), Cond,
-        DAG.getConstant(1, DL, Cond.getValueType()));
+        DAG.getConstant(APInt::getAllOnesValue(CondVT.getScalarSizeInBits()),
+                        DL, CondVT));
----------------
Why do we need getScalarSizeInBits() if we already know its i1?


https://reviews.llvm.org/D28550





More information about the llvm-commits mailing list