[PATCH] D28561: [ELF] - Move the addition of synthetics from addPredefinedSections()
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 11 10:26:30 PST 2017
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: ELF/Writer.cpp:1598-1600
+ EHdr->e_shstrndx = In<ELFT>::ShStrTab->OutSec
+ ? In<ELFT>::ShStrTab->OutSec->SectionIndex
+ : SHN_UNDEF;
----------------
I'd think this is slightly more readable.
if (In<ELFT>::ShStrTab->OutSec)
EHdr->e_shstrndx = In<ELFT>::ShStrTab->OutSec->SectionIndex;
https://reviews.llvm.org/D28561
More information about the llvm-commits
mailing list