[PATCH] D28569: Remove all variants of DWARFDie::getAttributeValueAs...() that had parameters that specified default values.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 09:53:20 PST 2017


clayborg added a comment.

I will leave the tests using getValueOr() for now as I would like it to fail nicely so we can get a complete snapshot of what is failing instead of crashing on any failure and not knowing how many others tests would fail. I will read up on EXPECT_* and make a separate change for switching arg order if needed.


https://reviews.llvm.org/D28569





More information about the llvm-commits mailing list