[PATCH] D28544: Remove all DWARFDie::getAttributeAsXXX() calls that returned default values and use new llvm::OptionalDefault template instead.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 09:13:36 PST 2017

Previous message: [PATCH] D28544: Remove all DWARFDie::getAttributeAsXXX() calls that returned default values and use new llvm::OptionalDefault template instead.
Next message: [PATCH] D28545: Add a compact dumping mode to `llvm-pdbdump`.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

clayborg abandoned this revision.
clayborg added a comment.

Looking in Optional,h I saw that is already has a getValueOr() function that does this. I will post a new patch that uses this since the title no longer makes sense.


https://reviews.llvm.org/D28544

Previous message: [PATCH] D28544: Remove all DWARFDie::getAttributeAsXXX() calls that returned default values and use new llvm::OptionalDefault template instead.
Next message: [PATCH] D28545: Add a compact dumping mode to `llvm-pdbdump`.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list