[PATCH] D28137: [Devirtualization] MemDep returns non-local !invariant.group dependencies

[Piotr Padlewski via Phabricator via llvm-commits]

Prazek added a comment.

Good news. I asked Teresa Johnson to run few benchmarks for me and this is results she got

"
Here are the results (ran 3x on ivybridge, showing both aggregated and non-aggregated improvements so it is easier to filter out noise). Looks like a real win in povray. The omnetpp improvement looks like noise, ditto for xalancbmk. Not sure about namd.
Teresa

  Reference: D28137_0 + D28137_1 + D28137_2
  (1): D28137_strictvtableptrs_0 + D28137_strictvtableptrs_1 + D28137_strictvtableptrs_2
  
             Benchmark             Base:Reference   (1)  
  -------------------------------------------------------
  spec/2006/fp/C++/444.namd                 25.51  +0.86%
  spec/2006/fp/C++/447.dealII               43.52  +0.44%
  spec/2006/fp/C++/450.soplex               41.91  +0.13%
  spec/2006/fp/C++/453.povray               35.35  +4.50%
  spec/2006/int/C++/471.omnetpp             26.11  +2.71%
  spec/2006/int/C++/473.astar               20.52  +0.21%
  spec/2006/int/C++/483.xalancbmk           34.58  +1.18%
  
  geometric mean                                   +1.42% 
  
  
  Reference: D28137_0 + D28137_1 + D28137_2
  (1): D28137_0
  (2): D28137_1
  (3): D28137_2
  (4): D28137_strictvtableptrs_0
  (5): D28137_strictvtableptrs_1
  (6): D28137_strictvtableptrs_2
  
             Benchmark             Base:Reference   (1)     (2)     (3)     (4)     (5)      (6)  
  ------------------------------------------------------------------------------------------------
  spec/2006/fp/C++/444.namd                 25.51  -0.55%  +0.08%  +0.47%  +0.94%  +1.14%   +0.51%
  spec/2006/fp/C++/447.dealII               43.52  +0.15%  -0.58%  +0.43%  +0.70%  +0.68%   -0.08%
  spec/2006/fp/C++/450.soplex               41.91  -1.46%  +1.36%  +0.10%  +0.36%  -0.84%   +0.86%
  spec/2006/fp/C++/453.povray               35.35  -0.88%  +0.25%  +0.62%  +3.76%  +4.47%   +5.26%
  spec/2006/int/C++/471.omnetpp             26.11  +1.33%  -0.82%  -0.51%  -1.09%  -1.16%  +10.37%
  spec/2006/int/C++/473.astar               20.52  -0.36%  -0.31%  +0.67%  +0.13%  +0.28%   +0.23%
  spec/2006/int/C++/483.xalancbmk           34.58  -0.99%  -0.36%  +1.35%  +0.80%  -0.82%   +3.55%
  
  geometric mean                                   -0.40%  -0.06%  +0.44%  +0.79%  +0.52%   +2.90%

"

Before this patch and handling of gep 0, there was -2% regression in povray, so this is very good sign!


https://reviews.llvm.org/D28137