[PATCH] D28560: [Object/ELF] - Allow to parse files with e_shstrndx set to SHN_UNDEF

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 07:25:53 PST 2017


grimar added a comment.

In https://reviews.llvm.org/D28560#642759, @emaste wrote:

> I think this LGTM but I'm curious if `!Index` was just from a misunderstanding, or if @rafael encountered an object with e_shstrndx == 0?


ELF::SHN_UNDEF has int value 0, I just replaced it with string constant to make code more clear.


https://reviews.llvm.org/D28560





More information about the llvm-commits mailing list