[PATCH] D28537: [X86][AVX512] Add support for ASHR v2i64/v4i64 support without VLX

[Elena Demikhovsky via Phabricator via llvm-commits]

delena added a comment.

I think that the cost model  changes should be in a separate commit.



================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:210
   static const CostTblEntry AVX512UniformConstCostTable[] = {
+    { ISD::SRA,  MVT::v4i64,   1 }, // psraq
+
----------------
Only this? What about v8i64, v2i64? and shift left?


================
Comment at: test/CodeGen/X86/avx512-cvt.ll:943
 ; KNL-NEXT:    vcmpltps %xmm0, %xmm1, %xmm0
-; KNL-NEXT:    vinsertps {{.*#+}} xmm0 = xmm0[0,1],zero,xmm0[1]
+; KNL-NEXT:    vpmovzxdq {{.*#+}} xmm0 = xmm0[0],zero,xmm0[1],zero
+; KNL-NEXT:    vpsllq $32, %xmm0, %xmm0
----------------
I think that this issue should be resolved, or at least understood prior to commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D28537