[PATCH] D28197: [X86] Re-organize tests for bypassing slow division (NFC)
Nikolai Bozhenov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 11 02:38:18 PST 2017
n.bozhenov added a comment.
> FYI you can put this information into phab if you so desire, see "edit related revisions".
Thanks! I overlooked this feature.
In https://reviews.llvm.org/D28197#633296, @RKSimon wrote:
> In https://reviews.llvm.org/D28197#633174, @n.bozhenov wrote:
>
> > > on the assumption that these are just renames
> >
> > That's not true. There are changes beside renaming. I will create an auxiliary review without renaming so that one can easily review the actual diff between old and new files.
>
>
> I don't think another review is necessary - just commit the renames only first and then make the changes in the now renamed files in a follow up commit. Make sense?
Makes sense. Let it be a renaming commit. The actual modifications are moved into https://reviews.llvm.org/D28551.
https://reviews.llvm.org/D28197
More information about the llvm-commits
mailing list