samparker added a comment. Ah ok, then I will get some unit tests together. For the build attributes overriding triple defaults, could I not just use remove the feature from the SubtargetFeatures in the following patch? cheers, sam https://reviews.llvm.org/D28281