[PATCH] D28545: Add a compact dumping mode to `llvm-pdbdump`.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp:577
+      for (const auto &IO : Tpi->getTypeIndexOffsets()) {
+        P.printString(llvm::formatv("Index: {0:x}, Offset: {1:N}",
+                                    IO.Type.getIndex(), (uint32_t)IO.Offset)
----------------
You have `using namespace llvm`.


================
Comment at: llvm/tools/llvm-pdbdump/llvm-pdbdump.cpp:589
+                "-ipi-record-bytes.\n";
+      errs().flush();
+      exit(1);
----------------
I think errs() is unbuffered, so you don't need this. Even if it is buffered, exit() should flush it.


https://reviews.llvm.org/D28545