[PATCH] D28433: [libFuzzer] Fix Sanitizer Coverage.

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 15:57:24 PST 2017


kcc added inline comments.


================
Comment at: lib/Fuzzer/FuzzerTracePC.cpp:268
 
+#if LIBFUZZER_WINDOWS
+#define COVERAGE_WEAK(Name) __declspec(dllexport) Name##_impl
----------------
please put this into FuzzerDefs.h


================
Comment at: lib/Fuzzer/FuzzerTracePC.cpp:269
+#if LIBFUZZER_WINDOWS
+#define COVERAGE_WEAK(Name) __declspec(dllexport) Name##_impl
+#else
----------------
Also, I think the name is wrong here, because these symbols are STRONG, not WEAK


Repository:
  rL LLVM

https://reviews.llvm.org/D28433





More information about the llvm-commits mailing list