[PATCH] D28122: RuntimeDyldELF: implement R_AARCH64_PREL64 reloc

[Yichao Yu via Phabricator via llvm-commits]

yuyichao added inline comments.


================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:353
   uint64_t FinalAddress = Section.getLoadAddressWithOffset(Offset);
   // Data should use target endian. Code should always use little endian.
   bool isBE = Arch == Triple::aarch64_be;
----------------
> Sorry I've misinformed you: A64 instructions are always little-endian. The difference occurs only for data relocations: ABS32/64 and PREL32/64. I've added all missing test cases in r291438

FYI. I included this comment trying to avoid precisely this confusion......

Also FWIW, this was part of https://reviews.llvm.org/D27629 ......


Repository:
  rL LLVM

https://reviews.llvm.org/D28122