[PATCH] D28525: [compiler-rt] Use macros to simplify weak alias for Windows and add some documentation.

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 12:11:20 PST 2017


kubabrecka added inline comments.


================
Comment at: lib/ubsan/ubsan_flags.cc:20
 #include "sanitizer_common/sanitizer_flag_parser.h"
+#include "sanitizer_common/sanitizer_win_defs.h"
 
----------------
I think this needs to be included only on Windows, because sanitizer_win_defs.h errors out if _MCS_VER is not defined. 


Repository:
  rL LLVM

https://reviews.llvm.org/D28525





More information about the llvm-commits mailing list