[PATCH] D28493: [zorg] Add Polly builder for ARM target

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Some comments on the implementation, but I share Tobias's concerns. Why not re-use the existing Poly builder?



================
Comment at: buildbot/osuosl/master/config/status.py:174
+            sendToInterestedUsers= False,
+            extraRecipients = ["efriedma at codeaurora.org"],
+            subject="Build %(builder)s Failure",
----------------
You don't need to add this to new builders.


================
Comment at: zorg/buildbot/builders/PollyBuilder.py:177
+    clang_srcdir = '%s/tools/clang' % llvm_srcdir
+    host_clang = "/local/clang+llvm-3.7.1-x86_64-linux-gnu-ubuntu-14.04"
+
----------------
Paths should be configuration parameters (see the ARM buildbots)


================
Comment at: zorg/buildbot/builders/PollyBuilder.py:212
+    cmakeCommand = ["cmake", "-G", "Ninja", "../%s" % llvm_srcdir,
+                    "-DLLVM_TARGETS_TO_BUILD='ARM;AArch64'",
+                    "-DLLVM_DEFAULT_TARGET_TRIPLE=arm-linux-gnueabi",
----------------
Targets and triples should be configuration parameters (see the ARM buildbots)


================
Comment at: zorg/buildbot/builders/PollyBuilder.py:228
+    f.addStep(ShellCommand(name="build_polly",
+                           command=["ninja", "-j16"],
+                           haltOnFailure=True,
----------------
Number of jobs should be a configuration parameter (see the ARM buildbots)


================
Comment at: zorg/buildbot/builders/PollyBuilder.py:243
+    f.addStep(ShellCommand(name="install_polly",
+                           command=["ninja", "install", "-j16"],
+                           warnOnFailure=True,
----------------
Number of jobs should be a configuration parameter (see the ARM buildbots)


================
Comment at: zorg/buildbot/builders/PollyBuilder.py:250
+    f.addStep(ShellCommand(name="test_polly",
+                           command=["ninja", "check-polly", "-j16"],
+                           haltOnFailure=True,
----------------
Number of jobs should be a configuration parameter (see the ARM buildbots)


https://reviews.llvm.org/D28493