[PATCH] D28386: Add the ability to iterate across all attributes in a DIE.

[Greg Clayton via Phabricator via llvm-commits]

clayborg marked 5 inline comments as done.
clayborg added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFFormValue.cpp:401
     default:
+      assert(false && "unsupported form");
       return false;
----------------
This is not unreachable. Newer DWARF might be passed to this at some point and it needs to fail correctly and just not parse the DIE which will cause all DIEs in a DWARFUnit to not be parsed or returned.


https://reviews.llvm.org/D28386