[PATCH] D28416: [PGO] Turn off comdat renaming in IR PGO by default

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 11:29:33 PST 2017


xur updated this revision to Diff 83833.
xur added a comment.

updated patch
Integrated David's review comments.
Note I need to conditionally check addresstaken bit in
canRenameComdatFunc() as this function is also used in renaming profile
variable which does not care if address-taken or not.
Also checking this bit requries the update of one test case.


https://reviews.llvm.org/D28416

Files:
  include/llvm/ProfileData/InstrProf.h
  lib/ProfileData/InstrProf.cpp
  lib/Transforms/Instrumentation/InstrProfiling.cpp
  lib/Transforms/Instrumentation/PGOInstrumentation.cpp
  test/Transforms/PGOProfile/Inputs/multiple_hash_profile.proftext
  test/Transforms/PGOProfile/comdat_internal.ll
  test/Transforms/PGOProfile/comdat_rename.ll
  test/Transforms/PGOProfile/indirect_call_profile.ll
  test/Transforms/PGOProfile/multiple_hash_profile.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28416.83833.patch
Type: text/x-patch
Size: 12072 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170110/4a74f235/attachment.bin>


More information about the llvm-commits mailing list