[PATCH] D28291: [ARM] Create SubtargetFeatures from build attributes

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Also, please add negative tests, to make sure that we still refuse support when no attributes are found, or when those that are found restrict the target.



================
Comment at: test/tools/llvm-objdump/ARM/v7a-subfeature.s:1
+@ RUN: llvm-mc < %s -triple armv7a -mattr=+vfp3,+neon,+fp16,+hwdiv-arm -filetype=obj | llvm-objdump -triple=arm -d - | FileCheck %s
+
----------------
If you pass the `-mattr`, it doesn't need to read the `.eabi_attributes`, so what does this test really test?


https://reviews.llvm.org/D28291