[PATCH] D28468: [X86] Fix for bugzilla 31576 - add support for "data32" instruction prefix

Marina Yatsina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 10:11:37 PST 2017


myatsina added a comment.

In https://reviews.llvm.org/D28468#641450, @niravd wrote:

> In https://reviews.llvm.org/D28468#639720, @myatsina wrote:
>
> > In https://reviews.llvm.org/D28468#639714, @niravd wrote:
> >
> > > Can you add some disassembler tests?
> >
> >
> > Do you mean to add tests for the tablegen diassembler change?
>
>
> Yes. I also notice that the testsuite is short on testing data16/data32. It'd be nice to add a few more tests for these as well.


Which kind of tests do you have in mind? Combination of "data16"/"data32" with additional instructions (like lgdt in the bug)? Some additional tests I'm missing?


Repository:
  rL LLVM

https://reviews.llvm.org/D28468





More information about the llvm-commits mailing list