[PATCH] D28429: Remove the restriction of ten types on AligedCharArrayUnion

[Michał Górny via Phabricator via llvm-commits]

mgorny added a subscriber: rnk.
mgorny added a comment.

This seems to be the source of new test failure on 32-bit x86:

  [==========] Running 1 test from 1 test case.
  [----------] Global test environment set-up.
  [----------] 1 test from AlignOfTest
  [ RUN      ] AlignOfTest.BasicAlignedArray
  /var/tmp/portage/sys-devel/llvm-9999/work/llvm-9999/unittests/Support/AlignOfTest.cpp:151: Failure
        Expected: alignof(T<long long>)
        Which is: 4
  To be equal to: alignof(AlignedCharArrayUnion<long long>)
        Which is: 8
  /var/tmp/portage/sys-devel/llvm-9999/work/llvm-9999/unittests/Support/AlignOfTest.cpp:153: Failure
        Expected: alignof(T<double>)
        Which is: 4
  To be equal to: alignof(AlignedCharArrayUnion<double>)
        Which is: 8
  [  FAILED  ] AlignOfTest.BasicAlignedArray (1 ms)

It should be noted that this specific commit fails due to assertion:

  /home/mgorny/llvm/unittests/Support/AlignOfTest.cpp:110:1: error: static assertion failed: Statically-computed alignment must be right
   static_assert(alignof(U) == alignof(uint64_t), "Statically-computed alignment must be right");
   ^

However, https://reviews.llvm.org/rL291515 (@rnk) following it builds fine and has this test failure.


Repository:
  rL LLVM

https://reviews.llvm.org/D28429