[PATCH] D28216: AVX-512: Truncate with unsigned saturation.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with minors



================
Comment at: ../lib/Target/X86/X86ISelLowering.cpp:31137
+    SrcVal = In.getOperand(1);
+  else if (ISD::isConstantSplatVector(In.getOperand(1).getNode(), C))
+    SrcVal = In.getOperand(0);
----------------
We canonicalize constants to RHS for UMIN/UMAX/SMIN/SMAX (see DAGCombiner::visitIMINMAX) so we only need this case.


================
Comment at: ../test/CodeGen/X86/avx512-trunc.ll:630
+  ret <32 x i8> %x6
+}
+
----------------
Is it worth adding PR31589 as usat_trunc_db_1024_mem as well?


Repository:
  rL LLVM

https://reviews.llvm.org/D28216