[PATCH] D27808: [globalisel] Initialize RegisterBanks with static data. Part 2 of 2.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added a comment.

In https://reviews.llvm.org/D27808#640396, @qcolombet wrote:

> Hi Daniel,
>
> LGTM but squash it with the other part of this patch.
>
> Cheers,
> -Quentin


Ok, I'll merge this with https://reviews.llvm.org/D27807



================
Comment at: include/llvm/CodeGen/GlobalISel/RegisterBankInfo.h:400
+  void setRegBankData(unsigned ID, const char *Name, unsigned Size,
+                      const uint32_t *CoveredClasses);
 
----------------
qcolombet wrote:
> Rename in createRegisterBank and merge the comment form the different methods.
Ok


================
Comment at: lib/Target/AArch64/AArch64GenRegisterBankInfo.def:21
 
+const uint32_t GPRCoverageData[] = {
+    // Classes 0-31
----------------
qcolombet wrote:
> I would squash this part with the tablgen patch.
I'd prefer to commit them in sequence to reach the same state (as per our discussion on D27807) if that's ok. Squashing the addition of this array into the last patch in the series will require me to squash an additional 5 patches too since they each depend on the previous one.


https://reviews.llvm.org/D27808